Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

information on hooks for hosted agent' #3014

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Conversation

mcncl
Copy link
Contributor

@mcncl mcncl commented Dec 3, 2024

No description provided.

@mcncl mcncl requested a review from a team as a code owner December 3, 2024 02:17
@github-actions github-actions bot added the agent label Dec 3, 2024
@buildkite-systems
Copy link

@gilesgas
Copy link
Contributor

gilesgas commented Dec 4, 2024

Thanks for your contribution @mcncl ! 🎉

I just want to confirm if your addition applies to all types of Buildkite hosted agents and not Windows hosted agents, since the heading level nesting you've applied makes it appear as though your addition is part of the Job hooks on Windows section (preview here), which I suspect is not meant to be the case.

If that's true, we'll need to remove to remove a hash/pound symbol from the start of your new heading to promote it. I'll do this in a subsequent suggested commit, along with some minor rewording.

pages/agent/v3/hooks.md Outdated Show resolved Hide resolved
@buildkite-systems buildkite-systems merged commit c90e0bf into main Dec 5, 2024
3 checks passed
@buildkite-systems buildkite-systems deleted the SUP-2789/agent_hooks branch December 5, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants