Allow min disk before clean to be customized #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturopie
force-pushed
the
allow-min-disk-before-clean-to-be-customized
branch
from
b5ff3da to
0ae78f3
Compare
|
@lox I haven't manually tested these changes, and I don't have access to this repo's CI so I'm not sure about its coverage. How much manual testing does this PR need? |
|
Really appreciate the help @arturopie! I'll review today. |
|
@arturopie argh, of course |
|
@lox @plasticine the CI is failing, but I have no visibility of it. Can you let me know what's the failure? |
|
@arturopie it's a linting error, I'm working on fixes in #623, nearly there. |
keithduncan
added
the
agent health
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the min disk threshold before docker cleanup as an CloudFormation parameter. It can be a unit (e.g. 120.3M, 1.5GB)
Thanks @lox for starting the work on this. I'll try to finish it with this PR.
I'm also adding unit tests. If you are ok with me adding unit tests with shunit2, I can create another PR for setting up a Dockerfile for running all unit tests.
This is a draft since I'm going through the comments from the original PR (#623)
Closes #465.