-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New output formats #146
Draft
DrJosh9000
wants to merge
9
commits into
main
Choose a base branch
from
plain-with-timestamps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
New output formats #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
force-pushed
the
plain-with-timestamps
branch
2 times, most recently
from
May 7, 2024 01:35
77eb235
to
73493ce
Compare
DrJosh9000
changed the title
WIP: Plain output format, optional timestamps
Plain output format, optional timestamps
May 7, 2024
Undo format option for webservice, and tweak the flag usage strings
DrJosh9000
force-pushed
the
plain-with-timestamps
branch
from
June 11, 2024 00:45
7bae2ad
to
86a933a
Compare
DrJosh9000
changed the title
Plain output format, optional timestamps
New output formats
Jun 12, 2024
@DrJosh9000 Mind including some example of the json log output here? |
Added to the description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two new flags:
--format
, which can be one ofhtml
,plain
,json
, orjson-plain
, and--timestamp-format
, which controls the output format of timestamps in plain modehtml
is what we do today, and remains the default.plain
is useful for a human investigating logs in a text editor, where ANSI escape sequences would get in the way.json
andjson-plain
structure each line as a JSON object, which is more easily consumed by machine, keeping the line content and line metadata (timestamp) separate.Since removing all ANSI escapes in
plain
mode would drop timestamp codes, it makes sense to have a way to optionally include the timestamps inplain
output, with some configurable formatting. Hence--timestamp-format
.There's a case for making
--timestamp-format
have useful effects when usinghtml
format, but this requires a bit of thought (both the timestamp format itself, and the XML processing instruction "element" containing it, should be configurable).Example outputs
cat fixtures/playwright.sh.raw | terminal-to-html --format=plain
cat fixtures/weather.sh.raw | terminal-to-html --format=plain
cat fixtures/playwright.sh.raw | terminal-to-html --format=json
cat fixtures/weather.sh.raw | terminal-to-html --format=json