SUP-2813: correct logic for pausing/resuming Dispatch on Queues and remove error with Default Cluster Queues #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizrabuya
previously approved these changes
Dec 13, 2024
tomowatt
changed the title
* removed isPausible as it would trigger Pausing when the Description was updated and State DispatchedPaused = false * compare Plan and State values to pause/resume dispatch else do nothing Signed-off-by: Tom Watt <[email protected]>
Currently, a cluster is allowed to: * Have no queues * Have queues, with none of them set to default queue Having this check doesn't make sense.
* State might be nil if Description not set on creation resulting in nil in response after update call Signed-off-by: Tom Watt <[email protected]>
…verall update Signed-off-by: Tom Watt <[email protected]>
Signed-off-by: Tom Watt <[email protected]>
This reverts commit ff9e775.
Signed-off-by: Tom Watt <[email protected]>
Signed-off-by: Tom Watt <[email protected]>
… = true" Signed-off-by: Tom Watt <[email protected]>
petetomasik
reviewed
Dec 16, 2024
mcncl
previously approved these changes
Dec 16, 2024
…arity and re-use * used "diag *diag.Diagnostics" instead of "resp *resource.UpdateResponse" so helper functions can be used in different operations e.g., Create Signed-off-by: Tom Watt <[email protected]>
Signed-off-by: Tom Watt <[email protected]>
Signed-off-by: Tom Watt <[email protected]>
mcncl
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isPausibleas it would trigger Pausing when the Description was updated and StateDispatchedPaused = falseDescriptioncausing the Queue to be pausedr.ClusterQueueUpdate.ClusterQueue.DispatchPausedis nil at the time of the original logic resulting inpanic: runtime error: invalid memory address or nil pointer dereferenceso changed to the Plan Value to be used for clarity else could be hardcoded asstate.DispatchPaused = types.BoolValue(true)orstate.DispatchPaused = types.BoolValue(false)(where appropritate)dispatch_paused = truedue to limitation with API.Includes fixes for #591 though there is a API issue resulting in the changes of Default Queues during updates to the Cluster Queue