feat(TimePicker): Add Save and Cancel buttons to Time Picker #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 1b4b044): https://novo-elements--pr1481-f-time-picker-5kp9nq7s.web.app (expires Wed, 29 Nov 2023 15:34:38 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f1783e19c2444272095017dd8ba433fff0ee3f61 |
monroepe
force-pushed
the
f/time-picker
branch
from
3b82d30 to
1b4b044
Compare
dvoegelin
approved these changes
Nov 30, 2023
MichaelDill
approved these changes
Nov 30, 2023
dvoegelin
pushed a commit
that referenced
this pull request
Dec 20, 2023
* feat(TimePicker): Add Save and Cancel buttons to Time Picker * TimePickerInput should emit save and cancel events as well
nadia-harrismartinez
pushed a commit
that referenced
this pull request
Jan 16, 2024
* feat(TimePicker): Add Save and Cancel buttons to Time Picker * TimePickerInput should emit save and cancel events as well
dvoegelin
added a commit
that referenced
this pull request
Jan 29, 2024
…mns (#1488) * Initial commit * Making sure currency field clips correctly * Cleaning up code * feat(TimePicker): Add Save and Cancel buttons to Time Picker (#1481) * feat(TimePicker): Add Save and Cancel buttons to Time Picker * TimePickerInput should emit save and cancel events as well * feat(Picker): Specify parent of picker components (#1483) * fix(imask): upping the max date on all date/text masks from 2030 to 2100 * upping node version for firebase action * setting firebase tools version instead of node version * fix(DatePickerInput): Default mask to a permissive number/separator r… (#1495) fix(DatePickerInput): Default mask to a permissive number/separator regex Co-authored-by: David Keyworth <[email protected]> * chore(deps-dev): bump @babel/traverse from 7.18.5 to 7.23.2 Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.18.5 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * fix(ExpansionPanelHeader): adding default heights to expansion-panel-header input properties * fix(Collection): fixing a strict=true TS compilation error * removing temp comments * feat(Progress): adding 'flash' state to progress bar * tweaking UX * making 'flash' progress bar dynamically fit its container * chore(deps-dev): bump follow-redirects from 1.15.2 to 1.15.4 (#1497) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.2 to 1.15.4. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.2...v1.15.4) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dan Voegelin <[email protected]> * rebasing next onto right-align-column-resizing branch * fixing yml file --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Peter Monroe <[email protected]> Co-authored-by: David Keyworth <[email protected]> Co-authored-by: Dan Voegelin <[email protected]> Co-authored-by: Alyssa Bryant <[email protected]> Co-authored-by: David Keyworth <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
dvoegelin
added a commit
that referenced
this pull request
Jan 31, 2024
…mns (#1488) * Initial commit * Making sure currency field clips correctly * Cleaning up code * feat(TimePicker): Add Save and Cancel buttons to Time Picker (#1481) * feat(TimePicker): Add Save and Cancel buttons to Time Picker * TimePickerInput should emit save and cancel events as well * feat(Picker): Specify parent of picker components (#1483) * fix(imask): upping the max date on all date/text masks from 2030 to 2100 * upping node version for firebase action * setting firebase tools version instead of node version * fix(DatePickerInput): Default mask to a permissive number/separator r… (#1495) fix(DatePickerInput): Default mask to a permissive number/separator regex Co-authored-by: David Keyworth <[email protected]> * chore(deps-dev): bump @babel/traverse from 7.18.5 to 7.23.2 Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.18.5 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * fix(ExpansionPanelHeader): adding default heights to expansion-panel-header input properties * fix(Collection): fixing a strict=true TS compilation error * removing temp comments * feat(Progress): adding 'flash' state to progress bar * tweaking UX * making 'flash' progress bar dynamically fit its container * chore(deps-dev): bump follow-redirects from 1.15.2 to 1.15.4 (#1497) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.2 to 1.15.4. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.2...v1.15.4) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dan Voegelin <[email protected]> * rebasing next onto right-align-column-resizing branch * fixing yml file --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Peter Monroe <[email protected]> Co-authored-by: David Keyworth <[email protected]> Co-authored-by: Dan Voegelin <[email protected]> Co-authored-by: Alyssa Bryant <[email protected]> Co-authored-by: David Keyworth <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add ability to have save and cancel buttons on the Time Picker which emit an event.
Verify that...
npm startandnpm run buildstill worksSafari,ChromeandFirefoxnpm run lintpassesnpm testpasses and code coverage is increasednpm run buildstill worksBullhorn Internal Developers
Novo AutomationScreenshots