feat(QueryBuilder): add isBetween option for number/timestamp fields #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit e108085): https://novo-elements--pr1597-f-bh-90170-wlrk05ai.web.app (expires Fri, 25 Oct 2024 15:32:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f1783e19c2444272095017dd8ba433fff0ee3f61 |
ndickerson
changed the title
ndickerson
force-pushed
the
f/BH-90170
branch
2 times, most recently
from
e1ad4d8 to
0fe08e9
Compare
davidkbh
previously approved these changes
Oct 18, 2024
monroepe
reviewed
Oct 18, 2024
projects/novo-elements/src/elements/form/extras/number-range/number-range.component.ts
Outdated
Show resolved
Hide resolved
monroepe
reviewed
Oct 18, 2024
...ts/novo-examples/src/form-controls/form/number-range-control/number-range-control-example.ts
Outdated
Show resolved
Hide resolved
monroepe
reviewed
Oct 18, 2024
...ts/novo-examples/src/form-controls/form/number-range-control/number-range-control-example.ts
Outdated
Show resolved
Hide resolved
monroepe
approved these changes
Oct 18, 2024
davidkbh
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the number range and support the between operator for both timestamps and numbers in the criteria builder.
Verify that...
npm startandnpm run buildstill worksSafari,ChromeandFirefoxnpm run lintpassesnpm testpasses and code coverage is increasednpm run buildstill worksBullhorn Internal Developers
Novo AutomationScreenshots