Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(QueryBuilder): Prevent a logic error normalizing dates #1599

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

davidkbh
Copy link
Collaborator

@davidkbh davidkbh commented Sep 9, 2024

Description

This format code is called when clearing values from inputs, which leads to an error when formatting "" that prevents some other logic.
Unit tests pending...

Verify that...

  • Any related demos were added and npm start and npm run build still works
  • New demos work in Safari, Chrome and Firefox
  • npm run lint passes
  • npm test passes and code coverage is increased
  • npm run build still works

Bullhorn Internal Developers

  • Run Novo Automation
Screenshots

Copy link
Contributor

github-actions bot commented Sep 9, 2024

Visit the preview URL for this PR (updated for commit cd56c77):

https://novo-elements--pr1599-f-date-format-error-j7drr5a3.web.app

(expires Thu, 31 Oct 2024 20:20:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f1783e19c2444272095017dd8ba433fff0ee3f61

@davidkbh davidkbh force-pushed the f/date-format-error branch from 6c56d04 to 8a3ceb2 Compare October 23, 2024 17:40
@davidkbh davidkbh marked this pull request as ready for review October 25, 2024 19:44
@davidkbh davidkbh merged commit cda59b9 into next Oct 28, 2024
10 checks passed
@davidkbh davidkbh deleted the f/date-format-error branch October 28, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants