Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RowChips): testing out supporting checkboxes in row chips #1615

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

dvoegelin
Copy link
Collaborator

@dvoegelin dvoegelin commented Oct 4, 2024

Description

just quickly testing out adding checkbox support for row chips

Verify that...

  • Any related demos were added and npm start and npm run build still works
  • New demos work in Safari, Chrome and Firefox
  • npm run lint passes
  • npm test passes and code coverage is increased
  • npm run build still works

Bullhorn Internal Developers

  • Run Novo Automation
Screenshots

Copy link
Contributor

github-actions bot commented Oct 4, 2024

Visit the preview URL for this PR (updated for commit 9cb4c9c):

https://novo-elements--pr1615-row-chip-checkbox-3hu4wnkb.web.app

(expires Wed, 16 Oct 2024 18:44:50 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f1783e19c2444272095017dd8ba433fff0ee3f61

@MichaelDill MichaelDill merged commit 2d9ed44 into next Nov 4, 2024
11 checks passed
@MichaelDill MichaelDill deleted the row-chip-checkbox branch November 4, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants