feat(Autocomplete): Clear the input field when the user loses focus #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not clear inputs when a blur event targets a field's overlay
|
Visit the preview URL for this PR (updated for commit db0da47): https://novo-elements--pr1618-f-autocomplete-clear-n61wykoe.web.app (expires Fri, 25 Oct 2024 13:55:50 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f1783e19c2444272095017dd8ba433fff0ee3f61 |
monroepe
reviewed
Oct 18, 2024
monroepe
previously approved these changes
Oct 18, 2024
kflo411
previously approved these changes
Oct 18, 2024
monroepe
approved these changes
Oct 18, 2024
kflo411
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The autocomplete input was appearing to clear out when users clicked away, but was just turning invisible. We've decided to actually clear the value, which still makes clear to the user that the text entered is not a full "value" (still needs a separator to turn it into a chip)
Verify that...
npm startandnpm run buildstill worksSafari,ChromeandFirefoxnpm run lintpassesnpm testpasses and code coverage is increasednpm run buildstill worksBullhorn Internal Developers
Novo AutomationScreenshots