Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Button): Set the native disabled attribute #1621

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Conversation

davidkbh
Copy link
Collaborator

@davidkbh davidkbh commented Oct 17, 2024

… events

Description

When we set up a element as a Button.ts component, we want to ensure the native disabled attribute is still set - as this is the best way of blocking keyboard tabbing access to the button.

Verify that...

  • Any related demos were added and npm start and npm run build still works
  • New demos work in Safari, Chrome and Firefox
  • npm run lint passes
  • npm test passes and code coverage is increased
  • npm run build still works

Bullhorn Internal Developers

  • Run Novo Automation
Screenshots

Copy link
Contributor

github-actions bot commented Oct 17, 2024

Visit the preview URL for this PR (updated for commit 44264c9):

https://novo-elements--pr1621-f-button-disabled-at-kv1594yh.web.app

(expires Fri, 25 Oct 2024 16:00:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f1783e19c2444272095017dd8ba433fff0ee3f61

@davidkbh davidkbh force-pushed the f/button-disabled-attr branch from aaa8959 to ed70fb0 Compare October 17, 2024 19:54
@davidkbh davidkbh changed the title fix(Button) - Set the native disabled attribute fix(Button): Set the native disabled attribute Oct 17, 2024
@davidkbh davidkbh force-pushed the f/button-disabled-attr branch from ed70fb0 to 8e79086 Compare October 17, 2024 20:34
@davidkbh davidkbh marked this pull request as ready for review October 18, 2024 15:58
@davidkbh davidkbh merged commit d0e55bd into next Oct 18, 2024
5 checks passed
@davidkbh davidkbh deleted the f/button-disabled-attr branch October 18, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants