Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lua client driver for KyotoTycoon using its binary protocol at ngx_lua #14

Merged
merged 1 commit into from
Aug 2, 2016
Merged

Conversation

sjnam
Copy link
Contributor

@sjnam sjnam commented Jul 27, 2016

Lua client driver for KyotoTycoon using its binary protocol

@bungle
Copy link
Owner

bungle commented Aug 2, 2016

Thanks but should you perhaps rename this project so that it can be installed alongside Cloudflares resty.kyototycoon?

@bungle bungle merged commit cc42712 into bungle:master Aug 2, 2016
@sjnam
Copy link
Contributor Author

sjnam commented Aug 2, 2016

@bungle
KT has three protocols, TSV-RPC, RESTful, and Binary. The first two are base on HTTP protocol. My lua-resty-kyototycoon implements binary protocol but cloudfare's is TSV-RPC on HTTP protocol. Thanks.

@bungle
Copy link
Owner

bungle commented Aug 2, 2016

@sjnam, I understand, but your library is resty.kyototycoon and CloudFlare's is also resty.kyototycoon. You could rename yours (as the CloudFlare's was prior work) to say resty.kyototycoon-bin or something so that the libs don't share the same namespace and same files. E.g. you cannot install both in the same namespace (and you need to manually but them in separate places).

@sjnam
Copy link
Contributor Author

sjnam commented Aug 2, 2016

@bungle Thank you for your advice. But I think that anyone who want to use lua KT client on openresty should choose one of the two, cloudflare's or mine. She or he don't have to install both in the same namespace because they has the same or similar functions.

@sjnam
Copy link
Contributor Author

sjnam commented Aug 3, 2016

@bungle I renamed module name to "resty.kyototycoon.binary" :-)

@bungle
Copy link
Owner

bungle commented Aug 3, 2016

@sjnam well, yes, but one OpenResty Server can service multiple applications, some using CloudFlare, and maybe newer ones using yours. I think the change of the name is good. In some point you could maybe try to merge with CloudFlare's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants