Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout #1

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Increase timeout #1

merged 1 commit into from
Oct 4, 2023

Conversation

abelsonlive
Copy link
Member

@abelsonlive abelsonlive commented Oct 4, 2023

This increases the timeout between message sends to 2 seconds and the intermittent wait to 30 seconds, though I noticed the line which added the one second timeout was commented out, so that may have been the issue.

@abelsonlive abelsonlive merged commit 4cb0bb8 into main Oct 4, 2023
1 check passed
@1jeanpaul1
Copy link
Contributor

1jeanpaul1 commented Oct 4, 2023

the api rate limit is 100/min

I think there’s a rate_limit_exceed error that would be returned by the API if it was a rate limit issue

I think the increase from 15 to 30 makes sense, but the 1 second wait time could probably be removed.

Or vise versa

but if we don’t care about speed then this is good too :)

@abelsonlive
Copy link
Member Author

the api rate limit is 100/min

I think there’s a rate_limit_exceed error that would be returned by the API if it was a rate limit issue

I think the increase from 15 to 30 makes sense, but the 1 second wait time could probably be removed.

Or vise versa

but if we don’t care about speed then this is good too :)

Thanks! Maria said she was okay waiting for now. We can bump it back down after messages go out tomorrow and we here back from Dialpad about the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants