-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP ignore IME key clicks #661
Conversation
We want to skip the usual special behavior for ENTER and DELETE when the user is using IME.
@iezer are there docs for the IME APIs? I was looking into it and I wasn't sure if FireFox and Chrome have the same APIs here, or if they are standard/non-standard etc. Looking good. |
@mixonic I found some docs here but I'm not sure if they're relevant. https://www.chromium.org/developers/design-documents/extensions/proposed-changes/apis-under-development/input-method-editor The IME interface is at the OS level so it's the same on all browsers and text-editors, even in the terminal! I just tested this on Firefox and Safari and it works. |
Sorry for asking, any update on this PR? Hope this could merge soon and the IME issue could be solved. :) |
If this bug remains for a long time, no Japanese or Koreans will use it. I WANT SOME- THING TO FIX IT... |
This problem troubles me such a long time. |
I strongly hope that this PR will be merged early. |
Merge it Please!!! |
@gpoitch The feature is important for all users who need input method. |
Thanks so much for reply. This PR has been proved to be effective by @soulteary. The author @iezer has pointed out that this PR solves problem #548, and this is the biggest problem for every asian user. The so called incomplete refers to issue #589. We can wait for people proposing a new PR. Please merge this PR first. |
I've checked, the PR is a partial fix. It's broken when you insert with IME to an empty section. e.g. typing |
@iezer You can replace The API is not supported by some browsers(IE), but it would not be worse. https://caniuse.com/#feat=mdn-api_keyboardevent_iscomposing. |
Superseded by #738 |
Partial fix for #548. This fixes Korean and Japanese input (using Input Method Editor IME) for most cases.
Editor is still broken when entering text at the beginning of a section. Still working on that. Fixing this will probably involve fixing #589, ie. don't do a full re-render when not needed. This also effects spellcheck and Android input.
Basically the keys Enter, Backspace, Space, Tab, and Arrows are all used to navigate and select within the IME editor so we want mobiledoc to ignore those.
Illustration of the bug:
Pressing Enter

Pressing Backspace
After fixed

Still broken at start of section