Changes to enable the build on Linux #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yowl
changed the title
jsturtevant
reviewed
Sep 3, 2024
| @@ -67,7 +67,8 @@ | |||
| <PrebuiltWasmToolsTarget Include="aarch64-macos" Rid="osx-arm64" Ext=".tar.gz" /> | |||
| <PrebuiltWasmToolsTarget Include="x86_64-linux" Rid="linux-x64" Ext=".tar.gz" /> | |||
| <PrebuiltWasmToolsTarget Include="x86_64-macos" Rid="osx-x64" Ext=".tar.gz" /> | |||
| <PrebuiltWasmToolsTarget Include="x86_64-windows" Rid="win-x64" Ext=".zip" ExeExt=".exe" /> | |||
| <!-- tar on non-Windows often cannot handle zip archives --> | |||
| <PrebuiltWasmToolsTarget Include="x86_64-windows" Rid="win-x64" Ext=".zip" ExeExt=".exe" Condition="$([MSBuild]::IsOSPlatform('Windows'))" /> | |||
| </ItemGroup> | |||
There was a problem hiding this comment.
This will have the result that, if built and published on Linux, there wouldn't be an .exe in the resulting nuget package.
There was a problem hiding this comment.
we could either document that it must publish on Windows and/or open an issue to make it more robust?
There was a problem hiding this comment.
Thanks, added #41 and referenced in the code.
jsturtevant
approved these changes
Sep 6, 2024
This was referenced Sep 6, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables
dotnet buildon linux.dotnet teststill fails and CI is not enabled for linux.I removed the PackageSourceMapping as it seemed to be causing a build failure on linux, interesting to see if the Windows build is ok without it.
Edit:
Fixed up the tests and added Linux to the build matrix. Renamed the artifacts to include the os name to avoid conflicts.
@jsturtevant is there anything else I should do for Linux ?