Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker-compose services #1767

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BboyKeen
Copy link

Hey there,

You'll find in this PR a few updates

  • Schema update scripts are inline with the use of the standard postgres user.
  • $USER variables are not used anymore in schema update scripts
  • Previously built images for Postgres/Postgis and Redis are not used anymore in docker-compose
  • We use the dedicated volumes feature for Postgres data now
  • The obsolete links directive was removed from the docker-compose

All tests are green in local with these updates

@BboyKeen BboyKeen force-pushed the upgrade-docker-compose branch 5 times, most recently from 2d62246 to d738324 Compare March 20, 2024 15:29
@lbesson
Copy link
Member

lbesson commented Mar 26, 2024

Hello, thanks for the PR (and the other ones)

I didn't see a notification, thus only seeing this now.

I'm wondering about the postgre image change: this image contains anonymized data from an old extract of c2c db, it's not used in the tests?

@BboyKeen
Copy link
Author

Interesting. I may have missed something for this part. However all tests are green without it so I think it's only used as dev fixtures.

I can revert this part if necessary but this image is quite old and it's not easily updatable..

Maybe we should prefer having a dumped anonymized SQL file to load at dev database init.

@lbesson
Copy link
Member

lbesson commented Apr 26, 2024

Hello, again sorry for having been very absent recently

I think we can merge this anyway, all tests pass, and I don't really see why we would need existing data for tests that don't use it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants