-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new LTag aliases: C# and V# for crag climbing routes #1860
base: master
Are you sure you want to change the base?
Conversation
Anyone interested to merge this? |
Hi @bohwaz , Thanks for your work. I've approved the PR, as the original writer of this extension to confirm that your work is fine from a technical POV. Though, I'm not anymore part of c2c anymore, so I can't make the decision to merge it. You can send a message to the developper forum on c2c to get someone to merge it if nobody answers here. Best! |
Thank you @cbeauchesne I'll do that :) |
awesome, I wanted more generic tables to help with raid descriptions as well |
however as mentioned in the forum there is a standard markdown extension / widely adopted syntax for table eg the githiub syntax using eg there is this extension of the markdown engine we use, we could try to integrate it: https://python-markdown.github.io/extensions/toc/ that would more in-line with most of the existing syntax which is standard markdown, and less confusing for new users who know markdown |
You probably mean https://python-markdown.github.io/extensions/tables/ ? |
I would be happy to have markdown tables as well, but we need to have some semantic meaning to identify climbing routes. Or I won't be able to automatically generate our local climbing topos books from the data I am entering in Camp2camp. I am sad that the forum guys pushed against this. I spent a considerable amount of time on this, and it just seems we can't get to have any evolution, which makes camptocamp irrelevant if it can't suit the open data needs of our days. |
Adding the link to the forum: https://forum.camptocamp.org/t/merge-pr-pour-les-tags-v-and-c/337899 |
I totally understand this feeling, and I deeply regret that the workflow
Could you give more details about those difficulties ? Maybe I could help, I've handled the post-migration v5 -> v6 and cleaned the whole DB (it was in a terrible shape after the migration), I may have some idea to help you to tackle this. |
This commit adds two new syntaxes for tables of lines, intended for use with crag climbing routes:
V is for "Voie", C is for "Climb", as R (could be used for Route) is already used for "Relay" and L (could mean "Line") is used for "Longueur".
When transformed to HTML, the V or C is removed, resulting in this:
(Table header added here to make it work with Github markdown syntax)
Apart from this, there is no difference with the handling of regular
R#
andL#
tags.This is useful for writing topos for regular crags, where a climb can have multiple lengths (longueurs) and relays. It's closer to what you would find in topo guidebooks.
I added a new test to make sure the aliases work properly.