Fix path matching logic #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Introduced support for dynamic URL pattern matching using parameters enclosed in `{}`.
2. Updated `Matcha` initializer to parse patterns and extract parameter values from matched URLs.
3. Enhanced test cases to validate the new parameterized matching functionality.
tanobe
approved these changes
Jul 24, 2024
tsoejima
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
既存のMatchaのマッチングロジックは、patternとして渡したもののPathのコンポーネント数が一致していないとマッチできないので、マッチできるように修正。
テストも通っていることを確認
e.g.)
urlのpathが
/my/something/pathだったときに、/my/{parameter}のpatternでsomething/pathを取得できるように。