feat: add goimports as a hook #518
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmajid2301
commented
Oct 17, 2024
| failed=false | ||
| for file in "$@"; do | ||
| # redirect stderr so that violations and summaries are properly interleaved. | ||
| if ! ${hooks.gotools.package}/bin/goimports ${hooks.goimports.settings.flags} -w "$file" 2>&1 |
There was a problem hiding this comment.
Is there a way to do with args instead of manually specifying flags here and setting them above?
There was a problem hiding this comment.
Don't think so, since $@ is already used for the files.
There was a problem hiding this comment.
If the tool is not too complicated, the general pattern is that we add dedicated options to make them show up in the docs of downstream projects (flake-parts, devenv).
Some hooks will have an extraFlags/extraOptions setting to capture everything. Use the existing hooks for inspiration.
sandydoo
requested changes
Oct 30, 2024
Co-authored-by: sander <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added go imports, https://pkg.go.dev/golang.org/x/tools/cmd/goimports as a hook