Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled localfile and remote storage for repository #179

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

wjgerritsen-0001
Copy link
Contributor

Rationale: currently repository is not usable for CLI clients, with injection a DefinitionStorage, either Remote via http or directly on filesystem, this becomes possible.

Still to be done (depends on opinion of @tpetter)

  • merge Repository and RepositoryBase (I don't see what the logic of the split is)
  • rename ServerFile to RepositoryFile
  • duplicate file access code in server/utilities.js and repository/storage/filesytemdefinitionstorage.ts - not DRY!

@wjgerritsen-0001 wjgerritsen-0001 changed the base branch from main to move-server-logic-to-client December 16, 2024 14:51
Note: this should be done in a different manner (named changing of fields, rather than generic), but for now generalized the behavior
And apply it for ExternalReference<TypeDefinition>
If a "type" attribute in a schema refers to something that does not end with ".type", it should not try to load a file
And refactor ExternalReference class a bit
Some functionality is not available in @cafienne/repository.
Preparing a Utilities class for moving logic from server to client.
Made separate webpack entries for "ide", "repository" and "server"
@tpetter tpetter force-pushed the move-server-logic-to-client branch from 7862533 to 6244f20 Compare December 18, 2024 15:21
@tpetter tpetter force-pushed the enabled-localfile-and-remote-storage-for-repository branch from 6fee1a5 to fb5b636 Compare December 18, 2024 18:07
@tpetter tpetter force-pushed the move-server-logic-to-client branch 5 times, most recently from e658100 to 421c78c Compare December 23, 2024 19:15
Base automatically changed from move-server-logic-to-client to main December 24, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants