Migrate hf trainer #287
Merged
Migrate hf trainer #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alex-Brooks <[email protected]> Signed-off-by: gkumbhat <[email protected]>
Co-authored-by: Alex-Brooks <[email protected]> Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
Co-authored-by: Alex-Brooks <[email protected]> Signed-off-by: gkumbhat <[email protected]>
Co-authored-by: Alex-Brooks <[email protected]> Signed-off-by: gkumbhat <[email protected]>
Co-authored-by: Alex-Brooks <[email protected]> Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
gkumbhat
requested review from
alex-jw-brooks,
evaline-ju,
gabe-l-hart and
tharapalanivel
as code owners
Signed-off-by: gkumbhat <[email protected]>
Co-authored-by: Alex-Brooks <[email protected]> Signed-off-by: gkumbhat <[email protected]>
Draft
Ssukriti
requested changes
Dec 3, 2023
There was a problem hiding this comment.
from the changes it seems like fine tuning was already using Trainer, you have now added it to prompt tuning as well. I think you meant to re-use some functions, hence you moved them to toolkit.
Prompt tuning is using launch_training and preprocessing from toolkit, but text_generation_local has its own definition of both functions, _launch_training. Code looks the same between both launch training, so maybe you forgot to change fine tuning to use toolkit as well?
|
@Ssukriti , I did this on purpose to avoid making too many refactors in one PR. I added a comment regarding that: https://github.com/caikit/caikit-nlp/pull/287/files#diff-3ca8e28141febc0ff5a812a8b7a2f92997f0098406b924bd4bdbcab680813cc3R73 |
Ssukriti
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes