Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Fix phpcs violation #30

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Fix phpcs violation #30

wants to merge 10 commits into from

Conversation

josegonzalez
Copy link
Member

No description provided.

@josegonzalez josegonzalez force-pushed the josegonzalez-patch-1 branch 4 times, most recently from e2ec832 to d883ff6 Compare February 29, 2016 07:16
@josegonzalez josegonzalez force-pushed the josegonzalez-patch-1 branch 2 times, most recently from 64df61f to 6199932 Compare February 29, 2016 07:35
@josegonzalez
Copy link
Member Author

@jadb looks like the changes in 2.1 completely break the plugin because of path changes (lolol bc). Any ideas as to what we can fix to get this working again?

@josegonzalez
Copy link
Member Author

We need to upgrade codeception to add 3.2 support because 2.0.x requires symfony/yaml 2.x and cakephp 3.2 requires symfony/yaml 3.x.

@lorenzo
Copy link
Member

lorenzo commented Mar 5, 2016

Why does cake 3 require yaml?

@jadb
Copy link
Contributor

jadb commented Mar 6, 2016

Not sure about cake but should be updating this plugin soon as I use it on new application and make changes. Which reminds me to ask, @josegonzalez would you be available for an interview?

@josegonzalez
Copy link
Member Author

@lorenzo no fucking idea.

I'm available.

@HavokInspiration
Copy link
Member

@lorenzo @josegonzalez If this is installing cakephp/app, symfony/yaml is required by the migrations plugin (which requires phinx, which requires it).

@dereuromark
Copy link
Member

Using composer show --tree should show the dependencies in a tree view.

@josegonzalez
Copy link
Member Author

@HavokInspiration gotcha. I wonder if I can create the app in --dev mode to avoid the yaml requirement.

Note that it wouldn't matter, since we still need both installed in dev...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants