Feat: in-person eligibility policies #2689
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
deployment-dev
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
angela-tran
commented
Feb 13, 2025
| @@ -10,6 +10,8 @@ | |||
| from .common import PemData, SecretNameField, template_path | |||
| from .claims import ClaimsProvider | |||
| from .transit import TransitAgency | |||
| from benefits.core.context import SystemName | |||
| from benefits.in_person.context import eligibility | |||
There was a problem hiding this comment.
I know we're wanting to discuss the naming for this copy context stuff. For now, I am just following the existing naming pattern but am aware that we don't necessarily like it.
angela-tran
commented
Feb 13, 2025
angela-tran
force-pushed
the
feat/in-person-policies
branch
from
dd9ccea to
e0a9209
Compare
the mocked agency used by the test did not have any flows, and the test was passing as a false positive. use the `mocked_session_flow` fixture so that the agency has a flow. this is similar to the fix in 3bf128c.
change the form to have a checkbox for each flow. when the user selects the radio button for a flow, the corresponding checkbox is shown, and the other checkboxes are hidden. implement a template specifically for this form.
angela-tran
force-pushed
the
feat/in-person-policies
branch
from
e0a9209 to
90fdd12
Compare
also fix spelling typo on copy for checkboxes.
previously we could rely on Django's default handling of the single `BooleanField`, but since we have multiple checkboxes now, and we don't want to require all of them, we need to implement our own logic to require that the checkbox that matches the selected flow was checked. also added Javascript to the template to show the checkbox for the case where the form didn't pass back-end validation and therefore we show the form again with what the user had selected.
angela-tran
force-pushed
the
feat/in-person-policies
branch
from
90fdd12 to
9582a61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2632
WIP