Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bookings for guests added by organizer get cancelled when rescheduled #17820

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: bookings for guests added by organizer get cancelled when rescheduled #17820

wants to merge 1 commit into from
+72 −8

Conversation

kart1ka
Copy link
Contributor

@kart1ka kart1ka commented Nov 24, 2024

What does this PR do?

Screencast.from.25-11-24.12.25.13.AM.IST.webm

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  1. Create a booking on team pro example account.
  2. Login to team pro example account and Go to /bookings/incoming page.
  3. Add guests to that booking.
  4. Now Reschedule the booking.
  5. Notice that the guests that were just added (by team pro example) are now included in the rescheduled booking.

@vercel Vercel
Copy link

vercel bot commented Nov 24, 2024

@kart1ka is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Nov 24, 2024
@graphite-app graphite-app bot requested a review from a team November 24, 2024 21:59
@github-actions github-actions bot added bookings area: bookings, availability, timezones, double booking teams area: teams, round robin, collective, managed event-types 🐛 bug Something isn't working labels Nov 24, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Nov 24, 2024 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (11/24/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (11/24/24)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (11/26/24)

1 label was added to this PR based on Keith Williams's automation.

Praashh
Praashh approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@github-actions GitHub Actions
Copy link
Contributor

E2E results are ready!

@anikdhabal anikdhabal marked this pull request as draft November 26, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Praashh Praashh Praashh approved these changes

Assignees
No one assigned
Labels
bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working community Created by Linear-GitHub Sync ready-for-e2e teams area: teams, round robin, collective, managed event-types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bookings for Guests Added by Organiser or Team Owner get cancelled when the booking is rescheduled
2 participants
@kart1ka @Praashh