Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Meeting URL does not save when changing the location to Gmeet or any static app #17840

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

anikdhabal
Copy link
Contributor

@anikdhabal anikdhabal commented Nov 25, 2024

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A-I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • N/A-I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

Copy link

vercel bot commented Nov 25, 2024

@anikdhabal is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot requested a review from a team November 25, 2024 20:34
@keithwillcode keithwillcode added the core area: core, team members only label Nov 25, 2024
@dosubot dosubot bot added bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working labels Nov 25, 2024
Copy link

graphite-app bot commented Nov 25, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (11/25/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Comment on lines -93 to -106
await BookingRepository.updateLocationById({
data: {
location: evt.location,
metadata: {
...(typeof booking.metadata === "object" && booking.metadata),
...bookingMetadataUpdate,
},
referencesToCreate,
},
where: {
id: booking.id,
},
});

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were previously performing this operation twice

@anikdhabal anikdhabal marked this pull request as draft November 25, 2024 20:35
@github-actions github-actions bot added 2 points Created by SyncLinear.com High priority Created by Linear-GitHub Sync workflows area: workflows, automations labels Nov 26, 2024
@anikdhabal anikdhabal marked this pull request as ready for review November 26, 2024 11:57
@dosubot dosubot bot added this to the v4.8 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 points Created by SyncLinear.com bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working core area: core, team members only High priority Created by Linear-GitHub Sync workflows area: workflows, automations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-4387] Meeting URL variable does not work when we change location.
2 participants