Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Changes #17858

Closed
wants to merge 2 commits into from
Closed

Added Changes #17858

wants to merge 2 commits into from

Conversation

SoloDevAbu
Copy link

What does this PR do?

  • Added a specific block to handle cancellation notifications separately
  • Adjusted the attachment logic in the sendEmail function to ensure calendar event attachments are only included if the event is not canceled.
  • Fixes Email Reminder Sent for Cancelled Meeting #17785

Bug fix
Add the necessary check so that email doesn't send to a cancelled event

@vercel Vercel
Copy link

vercel bot commented Nov 26, 2024

Someone is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Nov 26, 2024
@graphite-app graphite-app bot requested a review from a team November 26, 2024 18:05
@CLAassistant
Copy link

CLAassistant commented Nov 26, 2024 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ SoloDevAbu
❌ Abu

Abu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 26, 2024 •
edited
Loading

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Added Changes". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@github-actions github-actions bot added api area: API, enterprise API, access token, OAuth emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email labels Nov 26, 2024
@dosubot dosubot bot added the workflows area: workflows, automations label Nov 26, 2024
@github-actions github-actions bot added the 🐛 bug Something isn't working label Nov 26, 2024
@dosubot dosubot bot added the 🐛 bug Something isn't working label Nov 26, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Nov 26, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (11/26/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (11/26/24)

1 label was added to this PR based on Keith Williams's automation.

zomars
zomars requested changes Nov 27, 2024
View reviewed changes
Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 🙏

Unfortunately this doesn't seems to solve the original issue at #17858

Could you elaborate on how these changes are preventing scheduled reminders to stop being for cancelled bookings? Also could you add unit tests or some kind of evidence that your solution works?

​May you be well 🙏

packages/features/ee/workflows/lib/reminders/emailReminderManager.ts
Comment on lines +269 to +279
if (triggerEvent === WorkflowTriggerEvents.EVENT_CANCELLED) {
// Handle cancellation notifications
try {
if (!sendTo) throw new Error("No email addresses provided");
const addressees = Array.isArray(sendTo) ? sendTo : [sendTo];
const promises = addressees.map((email) => sendEmail({ to: email }, triggerEvent));
await Promise.all(promises);
} catch (error) {
log.error("Error sending cancellation email");
}
} else if (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm missing something, but could you elaborate on how is this different from the logic below where this belonged?

@github-actions GitHub Actions
Copy link
Contributor

E2E results are ready!

@github-actions GitHub Actions
Copy link
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Dec 12, 2024
@anikdhabal
Copy link
Contributor

Close due to inactive

@anikdhabal anikdhabal closed this Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zomars zomars zomars requested changes

Assignees
No one assigned
Labels
api area: API, enterprise API, access token, OAuth 🐛 bug Something isn't working community Created by Linear-GitHub Sync emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email ready-for-e2e Stale workflows area: workflows, automations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Email Reminder Sent for Cancelled Meeting
4 participants
@SoloDevAbu @CLAassistant @anikdhabal @zomars