fix: cancel workflows on cancel booking

[VK-RED]

What does this PR do?

• Fixes [CAL-4779] cancelling in app.cal.com does not cancel workflow #17806
• Fixes CAL-4779

Removed deleteScheduledSend function in scheduledEmailRemainder cron api, as this lead to removing the cancelled label on the scheduled emails, thus causing the users to receive emails for cancelled event.

According to sendGrid docs :

When a Batch is canceled, all messages associated with that batch will stay in your sending queue, but when their send_at value is reached, they will be discarded instead of attempting delivery.

Link to SendGrid docs

Previously ( when deleteScheduledSend is present )

Event Created

Event Cancelled

Simulated a Cron

Simulated a cron to execute deleteScheduledSend to delete emails in the queue.
https://github.com/calcom/cal.com/blob/main/packages/features/ee/workflows/api/scheduleEmailReminders.ts#L80

Ideally this cron action should have deleted the emails in the queue, and the users should not get any email regarding the cancelled booking

Email Received on Cancelled Booking

Did not received SMS or Whatsapp Reminder, but still received email on the cancelled booking.

Updated Changes ( deleteScheduledSend is removed )

Event Created

Event Cancelled

Again Simulated the cron

https://github.com/calcom/cal.com/blob/main/packages/features/ee/workflows/api/scheduleEmailReminders.ts#L80

No Emails received on Cancelled Booking

No emails , SMS or Whatsapp reminder is received.

Mandatory Tasks (DO NOT REMOVE)

• I have self-reviewed the code (A decent size PR without self-review might be rejected).
• I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
• I confirm automated tests are in place that prove my fix is effective or that my feature works.

[vercel]

@VK-RED is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

[graphite-app]

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (11/27/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (11/27/24)

1 label was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (11/27/24)

1 reviewer was added to this PR based on Keith Williams's automation.

[Praashh]

@VK-RED would be great if you add a loom video.

[VK-RED]

Hi @Praashh here is a screen recording

Screencast

Screencast.from.2024-11-27.18-38-30.mp4

No Emails Received

[keithwillcode]

@CarinaWolli Can you please take a look at this one? 🙏