-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ai translations description for atoms #17875
Changes from 1 commit
44312f7
1aaa535
1760472
0b77914
65af871
1c5cef2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
import { m } from "framer-motion"; | ||
import { useSession } from "next-auth/react"; | ||
import dynamic from "next/dynamic"; | ||
import { useEffect, useMemo } from "react"; | ||
import { shallow } from "zustand/shallow"; | ||
|
@@ -12,7 +11,6 @@ import { EventMetaBlock } from "@calcom/features/bookings/components/event-meta/ | |
import { useTimePreferences } from "@calcom/features/bookings/lib"; | ||
import type { BookerEvent } from "@calcom/features/bookings/types"; | ||
import { useLocale } from "@calcom/lib/hooks/useLocale"; | ||
import { locales as i18nLocales } from "@calcom/lib/i18n"; | ||
import { EventTypeAutoTranslatedField } from "@calcom/prisma/enums"; | ||
|
||
import { fadeInUp } from "../config"; | ||
|
@@ -31,6 +29,8 @@ export const EventMeta = ({ | |
isPending, | ||
isPlatform = true, | ||
classNames, | ||
locale, | ||
i18nLocales, | ||
}: { | ||
event?: Pick< | ||
BookerEvent, | ||
|
@@ -61,8 +61,9 @@ export const EventMeta = ({ | |
eventMetaTitle?: string; | ||
eventMetaTimezoneSelect?: string; | ||
}; | ||
locale?: string | null; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. shouldn't this be |
||
i18nLocales: string[]; | ||
}) => { | ||
const session = useSession(); | ||
const { setTimezone, timeFormat, timezone } = useTimePreferences(); | ||
const selectedDuration = useBookerStore((state) => state.selectedDuration); | ||
const selectedTimeslot = useBookerStore((state) => state.selectedTimeslot); | ||
|
@@ -107,7 +108,7 @@ export const EventMeta = ({ | |
: isHalfFull | ||
? "text-yellow-500" | ||
: "text-bookinghighlight"; | ||
const userLocale = session.data?.user.locale ?? navigator.language; | ||
const userLocale = locale ?? navigator.language; | ||
const translatedDescription = (event?.fieldTranslations ?? []).find( | ||
(trans) => | ||
trans.field === EventTypeAutoTranslatedField.DESCRIPTION && | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,6 +23,7 @@ import { getLastBookingResponse } from "@calcom/features/bookings/Booker/utils/l | |
import { useBrandColors } from "@calcom/features/bookings/Booker/utils/use-brand-colors"; | ||
import { DEFAULT_LIGHT_BRAND_COLOR, DEFAULT_DARK_BRAND_COLOR, WEBAPP_URL } from "@calcom/lib/constants"; | ||
import { useRouterQuery } from "@calcom/lib/hooks/useRouterQuery"; | ||
import { locales as i18nLocales } from "@calcom/lib/i18n"; | ||
import { BookerLayouts } from "@calcom/prisma/zod-utils"; | ||
|
||
type BookerWebWrapperAtomProps = BookerProps; | ||
|
@@ -181,6 +182,11 @@ export const BookerWebWrapper = (props: BookerWebWrapperAtomProps) => { | |
theme: event.data?.profile.theme, | ||
}); | ||
|
||
const areInstantMeetingParametersSet = !!event.data?.instantMeetingParameters | ||
? searchParams && | ||
event.data.instantMeetingParameters.every((param) => Array.from(searchParams.values()).includes(param)) | ||
: true; | ||
|
||
return ( | ||
<BookerComponent | ||
{...props} | ||
|
@@ -219,6 +225,9 @@ export const BookerWebWrapper = (props: BookerWebWrapperAtomProps) => { | |
schedule={schedule} | ||
verifyCode={verifyCode} | ||
isPlatform={false} | ||
areInstantMeetingParametersSet={areInstantMeetingParametersSet} | ||
userLocale={session?.user.locale} | ||
i18nLocales={i18nLocales} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm passing a prop doesn't seem optimal. I'd suggest importing it from |
||
/> | ||
); | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
double checking: you don't need to pass
userLocale
here?