Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce abnormal spacing in calendar invite #19290

Merged
merged 5 commits into from
Feb 20, 2025
Merged

Conversation

retrogtx
Copy link
Contributor

@retrogtx retrogtx commented Feb 14, 2025

What does this PR do?

https://www.loom.com/share/1709011d33e2442186efbde38ebdd56d?sid=ae9c2e7a-e9e5-4740-acad-c12a9825b222

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

You can run -> yarn test packages/lib/CalEventParser.test.ts

image

or watch the loom to book meetings manually and check the spacing (requires google calendar to be connected) -> https://www.loom.com/share/1709011d33e2442186efbde38ebdd56d?sid=ae9c2e7a-e9e5-4740-acad-c12a9825b222

Copy link

vercel bot commented Feb 14, 2025

@retrogtx is attempting to deploy a commit to the cal-staging Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Feb 14, 2025
@graphite-app graphite-app bot requested a review from a team February 14, 2025 07:21
@github-actions github-actions bot added Low priority Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input labels Feb 14, 2025
@keithwillcode keithwillcode added the community-interns The team responsible for reviewing, testing and shipping low/medium community PRs label Feb 14, 2025
@dosubot dosubot bot added the 🐛 bug Something isn't working label Feb 14, 2025
Copy link

graphite-app bot commented Feb 14, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/14/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (02/14/25)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (02/20/25)

1 label was added to this PR based on Keith Williams's automation.

@retrogtx
Copy link
Contributor Author

if teamMembers.length is 0, using && would actually insert "0" into the string instead of an empty string, which is probably not what we want

That space should be empty as it is because it might be optional

adding && will return the value itself if it's false etc

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ retrogtx
❌ TusharBhatt1
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

github-actions bot commented Feb 20, 2025

E2E results are ready!

@retrogtx retrogtx merged commit 3f042a1 into calcom:main Feb 20, 2025
33 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync community-interns The team responsible for reviewing, testing and shipping low/medium community PRs Low priority Created by Linear-GitHub Sync ready-for-e2e ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-5050] Reduce spaces in calendar invite description.
4 participants