-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reduce abnormal spacing in calendar invite #19290
Conversation
@retrogtx is attempting to deploy a commit to the cal-staging Team on Vercel. A member of the Team first needs to authorize it. |
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (02/14/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (02/14/25)1 label was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (02/20/25)1 label was added to this PR based on Keith Williams's automation. |
if teamMembers.length is 0, using && would actually insert "0" into the string instead of an empty string, which is probably not what we want That space should be empty as it is because it might be optional adding && will return the value itself if it's false etc |
|
E2E results are ready! |
What does this PR do?
https://www.loom.com/share/1709011d33e2442186efbde38ebdd56d?sid=ae9c2e7a-e9e5-4740-acad-c12a9825b222
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
You can run ->
yarn test packages/lib/CalEventParser.test.ts
or watch the loom to book meetings manually and check the spacing (requires google calendar to be connected) -> https://www.loom.com/share/1709011d33e2442186efbde38ebdd56d?sid=ae9c2e7a-e9e5-4740-acad-c12a9825b222