Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Clean out old code, no longer needed #19323

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

emrysal
Copy link
Contributor

@emrysal emrysal commented Feb 17, 2025

What does this PR do?

Remove old tests for old logic that shouldn't be used. throw an error and enforce the use of dateRanges. set no-check on dead code; but we should consider reviving.

@emrysal emrysal requested a review from a team as a code owner February 17, 2025 18:55
@keithwillcode keithwillcode added core area: core, team members only foundation labels Feb 17, 2025
zomars
zomars previously approved these changes Feb 17, 2025
Copy link

graphite-app bot commented Feb 17, 2025

Graphite Automations

"Add ready-for-e2e label" took an action on this PR • (02/17/25)

1 label was added to this PR based on Keith Williams's automation.

Copy link

vercel bot commented Feb 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal-com-ui-playground ❌ Failed (Inspect) Feb 17, 2025 7:20pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2025 7:20pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2025 7:20pm

@emrysal emrysal enabled auto-merge (squash) February 17, 2025 19:34
@emrysal emrysal merged commit 84b265c into main Feb 17, 2025
38 of 39 checks passed
@emrysal emrysal deleted the refactor/remove-old-slot-logic branch February 17, 2025 19:39
Copy link
Contributor

E2E results are ready!

nayan-bagale pushed a commit to nayan-bagale/cal.com that referenced this pull request Feb 18, 2025
* refactor: Clean out old code, no longer needed

* Removed a sneaky one keen to stay behind
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants