Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #19318 Line breaks not working in editor #19327

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Jynx2004
Copy link

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

Copy link

vercel bot commented Feb 18, 2025

@Jynx2004 is attempting to deploy a commit to the cal-staging Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Feb 18, 2025
@graphite-app graphite-app bot requested a review from a team February 18, 2025 05:20
@github-actions github-actions bot added event-types area: event types, event-types Medium priority Created by Linear-GitHub Sync 🐛 bug Something isn't working labels Feb 18, 2025
@Jynx2004
Copy link
Author

Please review the changes and let me know if i can still improve the solution

Copy link

graphite-app bot commented Feb 18, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/18/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (02/18/25)

1 label was added to this PR based on Keith Williams's automation.

Copy link
Contributor

@TusharBhatt1 TusharBhatt1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , can you add a quick loom (before & After)

@Jynx2004
Copy link
Author

LGTM , can you add a quick loom (before & After)

Yes Sure

@dosubot dosubot bot added this to the v5.1 milestone Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync event-types area: event types, event-types Medium priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-5177] Line breaks not working in editor
2 participants