perf: run ssrInit() at root layout
#19460
Merged
+25
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbjORbj
changed the title
ssrInit() at root layout
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
dosubot
bot
added
the
performance
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (02/21/25)1 reviewer was added to this PR based on Keith Williams's automation. |
E2E results are ready! |
hbjORbj
commented
Feb 23, 2025
| export default async function PageWrapperLayout({ children }: { children: React.ReactNode }) { | ||
| const h = headers(); | ||
| const nonce = h.get("x-nonce") ?? undefined; | ||
|
|
||
| const context = buildLegacyCtx(headers(), cookies(), {}, {}); | ||
| const ssr = await ssrInit(context); |
hbjORbj
commented
Feb 23, 2025
| export default async function BookingPageWrapperLayout({ children }: { children: React.ReactNode }) { | ||
| const h = headers(); | ||
| const nonce = h.get("x-nonce") ?? undefined; | ||
| const context = buildLegacyCtx(h, cookies(), {}, {}); | ||
| const ssr = await ssrInit(context); |
hbjORbj
commented
Feb 23, 2025
| @@ -56,6 +59,7 @@ export default async function RootLayout({ children }: { children: React.ReactNo | |||
| ? getFallbackProps() | |||
| : await getInitialProps(fullUrl); | |||
|
|
|||
| const ssr = await ssrInit(buildLegacyCtx(h, cookies(), {}, {})); | |||
There was a problem hiding this comment.
added here (higher level in hierarchy)
eunjae-lee
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
ssrInit()is a function that prefetches i18n translations and some important data (feature flags, team plan, session, user data): https://github.com/calcom/cal.com/blob/main/apps/web/server/lib/ssr.ts#L57ssrInit()is currently ran at(use-page-wrapper)/layout.tsxand(booking-page-wrapper)/layout.tsxapp/layout.tsx)Mandatory Tasks (DO NOT REMOVE)
How should this be tested?