Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the intro to the QoS Profile. #395

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

RandyLevensalor
Copy link
Collaborator

What type of PR is this?

Add one of the following kinds:

  • documentation

What this PR does / why we need it:

Expands on the intro to the QoS Profile to include it's intended use.

Which issue(s) this PR fixes:

Fixes #393

Special notes for reviewers:

@tanjadegroot this should address your feedback in #383 (comment). Please review.

Changelog input

 release-note
Updated top level description of QoS Profile.

Additional documentation

This section can be blank.

docs

Copy link
Contributor

@benhepworth benhepworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

eric-murray
eric-murray previously approved these changes Jan 17, 2025
Copy link
Collaborator

@eric-murray eric-murray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I'll even let you get away with your spelling of behaviour!

@hdamker
Copy link
Collaborator

hdamker commented Jan 17, 2025

@tanjadegroot proposed in #383 (comment) for line 17:

change: communication service provider --> API provider
possibly also change: API invoker --> API consumer

She also proposed in #383 (comment) to change multiple occurrences of "network operator" with "API provider" (background is that the API consumer is requesting the service from an API provider platform which is not necessarily directly the network operator (but could be)).

@hdamker hdamker added the Spring25 Issue in scope of Spring25 meta-release cycle label Jan 21, 2025
@RandyLevensalor
Copy link
Collaborator Author

@tanjadegroot proposed in #383 (comment) for line 17:

change: communication service provider --> API provider
possibly also change: API invoker --> API consumer

She also proposed in #383 (comment) to change multiple occurrences of "network operator" with "API provider" (background is that the API consumer is requesting the service from an API provider platform which is not necessarily directly the network operator (but could be)).

I don't think that API provider makes sense in this context. The attributes in the QoS Profiles would be defined by the network operator or at the very least approved and supported by the network operator, regardless if someone is hosting the API on their behalf.

Copy link
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hdamker
Copy link
Collaborator

hdamker commented Jan 24, 2025

I don't think that API provider makes sense in this context. The attributes in the QoS Profiles would be defined by the network operator or at the very least approved and supported by the network operator, regardless if someone is hosting the API on their behalf.

@RandyLevensalor I have a different view here, an API provider acting as aggregator might decide to offer only a subset or even an own defined set of profiles, which the provider is then mapping to QoS Profiles of underlying communication service provider.
But I propose that this is a different issue and PR, which I will create as sub issue of #387.

@hdamker hdamker merged commit 948c470 into camaraproject:main Jan 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Spring25 Issue in scope of Spring25 meta-release cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a simple explanation of what a QoS profile is
5 participants