-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the intro to the QoS Profile. #395
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I'll even let you get away with your spelling of behaviour!
@tanjadegroot proposed in #383 (comment) for line 17:
She also proposed in #383 (comment) to change multiple occurrences of "network operator" with "API provider" (background is that the API consumer is requesting the service from an API provider platform which is not necessarily directly the network operator (but could be)). |
I don't think that API provider makes sense in this context. The attributes in the QoS Profiles would be defined by the network operator or at the very least approved and supported by the network operator, regardless if someone is hosting the API on their behalf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@RandyLevensalor I have a different view here, an API provider acting as aggregator might decide to offer only a subset or even an own defined set of profiles, which the provider is then mapping to QoS Profiles of underlying communication service provider. |
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Expands on the intro to the QoS Profile to include it's intended use.
Which issue(s) this PR fixes:
Fixes #393
Special notes for reviewers:
@tanjadegroot this should address your feedback in #383 (comment). Please review.
Changelog input
Additional documentation
This section can be blank.