Clarify sinkCredentials expiration #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlurien
requested review from
hdamker,
eric-murray and
RandyLevensalor
as code owners
eric-murray
approved these changes
Jan 17, 2025
hdamker
changed the title
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Adapt description to the latest Commonalities guidelines.
In order to be functional, the provided sinkCredentials must be valid at the moment of sending the events. For quality-on-demand, it implies that the validity of the provided credentials must be longer than the underlying QoS session.
For QoD Provisioning, as expiration of the provisioning is indefinite, if provided, an access token would need to be valid until the provisioning is terminated by the client.
Which issue(s) this PR fixes:
Fixes #385
Special notes for reviewers:
For QoD Provisioning, a mechanism that allows refreshing tokens would be more suitable than just providing a valid access token, so the sentence about that only ACCESS_TOKEN type is supported is deprecated, allowing implementations to support a better mechanism.
Changelog input
Additional documentation