Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding MinerU Extractor #1529

Merged
merged 19 commits into from
Feb 14, 2025
Merged

feat: adding MinerU Extractor #1529

merged 19 commits into from
Feb 14, 2025

Conversation

GitHoobar
Copy link
Collaborator

Description

adding MinerU extractor

Motivation and Context

Why is this change required? What problem does it solve?
close #1521

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • mineru implementation

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@GitHoobar
Copy link
Collaborator Author

note for self: add tests

@GitHoobar GitHoobar marked this pull request as ready for review February 3, 2025 17:00
@Wendong-Fan Wendong-Fan changed the title adding MinerU Extractor feat: adding MinerU Extractor Feb 4, 2025
@Wendong-Fan Wendong-Fan added this to the Sprint 22 milestone Feb 4, 2025
Copy link
Collaborator

@MuggleJinx MuggleJinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi GitHoobar! Thanks you for the nice contribution!
Overall it looks good! I left some comments, please take a look!
I am still requesting for the API key, so I am unable to run the examples, maybe other reviewers can double check with the examples.

@GitHoobar GitHoobar requested a review from MuggleJinx February 7, 2025 14:28
Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GitHoobar 's great contribution! Overall looks great, left some comments below~

@GitHoobar
Copy link
Collaborator Author

@Wendong-Fan this is ready, we can merge it.

@Wendong-Fan Wendong-Fan merged commit 5d1296c into master Feb 14, 2025
5 of 6 checks passed
@Wendong-Fan Wendong-Fan deleted the mineru branch February 14, 2025 11:26
apokryphosx pushed a commit that referenced this pull request Feb 16, 2025
Co-authored-by: Wendong-Fan <[email protected]>
Co-authored-by: Wendong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Feature Request] Integrate MinerU
3 participants