[MultiThread] Fix error not being thrown on manifest update #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1651 We had an issue in multithreading mode where we would not trigger an error (and stop playback) if a Manifest request failed in all its attempt unless it was the first manifest request. The reason was simple: we didn't link a `ManifestFetcher`'s `error` event to an actual RxPlayer error. It worked for the initial request because it leads to the rejection of our internal initial-loading promise with that error.
peaBerberian
added
Priority: 0 (Very high)
|
Automated performance checks have been performed on commit Tests results✅ Tests have passed. Performance tests 1st run outputNo significative change in performance for tests:
If you want to skip performance checks for latter commits, add the |
Florent-Bouisset
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1651
We had an issue in multithreading mode where we would not trigger an error (and stop playback) if a Manifest request failed in all its attempt unless it was the first manifest request.
The reason was simple: we didn't link a
ManifestFetcher'serrorevent to an actual RxPlayer error. It worked for the initial request because it leads to the rejection of our internal initial-loading promise with that error.