Make our launch_static_server script runnable as a script
#1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peaBerberian
force-pushed
the
misc/script-static-server
branch
3 times, most recently
from
408387d to
56dec10
Compare
|
Automated performance checks have been performed on commit Tests results✅ Tests have passed. Performance tests 1st run outputNo significative change in performance for tests:
If you want to skip performance checks for latter commits, add the |
peaBerberian
force-pushed
the
misc/script-static-server
branch
from
56dec10 to
d1b7087
Compare
|
Automated performance checks have been performed on commit Tests results✅ Tests have passed. Performance tests 1st run outputNo significative change in performance for tests:
If you want to skip performance checks for latter commits, add the |
I wanted today to run an HTTPS server serving local files quickly to test something only locally. What I do normally was to rely on rely on the `http-server` npm package, which may be the better way, but I always forget the syntax wanted to provide my certificate and key file (my self-signed ones for localhost). We also have a much simpler `launch_static_server.mjs` script which does that, and which has the main advantage that we're more used to it, as we use it to run tests, our demo locally and so on. But that file was only exported as an ES6 module and not as a script. Consequently it only worked if imported and ran from another JS file, but not by running directly through node.js. Moreover, I know that @FlorentBouisset had the same need two days ago. So I thought it could in the end also run as a script. The main ""difficulty"" is here to process flags but we already do that in a variety of other scripts, so it was quick to add. I could do my tests.... under I'll admit a little more time than if I just did a `npx http-server --help`, but where's the fun in that?
peaBerberian
force-pushed
the
misc/script-static-server
branch
from
d1b7087 to
ad37243
Compare
|
Automated performance checks have been performed on commit Tests results✅ Tests have passed. Performance tests 1st run outputNo significative change in performance for tests:
If you want to skip performance checks for latter commits, add the |
Florent-Bouisset
approved these changes
Mar 4, 2025
peaBerberian
added
the
script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted today to run an HTTPS server serving local files quickly to test something only locally.
What I did normally was to rely on the
http-servernpm package, which may be the better way, but I always forget the syntax wanted to provide my TLS certificate and key files (my self-signed ones for localhost).We also have a much simpler
launch_static_server.mjsscript which does that, and which has the main advantage that we're more used to it, as we use it to run tests, our demo locally and so on.But that file was only exported as an ES6 module and not as a script. Consequently it only worked if imported and ran from another JS file, but not by running it directly through node.js.
Moreover, I know that @Florent-Bouisset had the same need two days ago.
So I thought it could in the end also run as a script. The main ""difficulty"" is here to process flags but we already do that in a variety of other scripts, so it was quick to add.
I could do my tests.... under I'll admit a little more time than if I just did a
npx http-server --help, but where's the fun in that?