-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semi-finally rename interface elements #235
Comments
related: #237 |
|
I can't remember the last time I actually looked at gene-normalizer, but looking at it now makes me realize it could use a nice refactor. Seems like a lot of the code was initially done 3 years ago and there are better ways to write / maybe even code that isn't necessary |
The various concept names like "BaseGene", "Gene", and then the VRS 2.x "Gene" should be renamed to disambiguate them more. I think we should stick with the VRS Gene as much as possible (cf that one GH issue) and if we need to have other objects, call them something more specific like SourceGene or UngroupedGene. |
|
Yeah, I think so -- but I do think we should plan on making as many of these changes as possible within a single discrete release to minimize headaches from updating |
I think I've successfully broken out everything listed here into separate issues. |
create_db
->get_db
orget_db_connection
q
parameter a different/longer namesources=
andexclude_sources=
QueryHandler
class nameroutes.py
instead ofmain.py
gene_norm_serve
or something to that effect (or maybe provide different CLI options for gunicorn/uvicorn/etc)search
, the way to include and exclude source names is kind of clumsygene.database.database
givesfrom datetime import datetime
vibes. not desirable.The text was updated successfully, but these errors were encountered: