Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: Remove ChromosomeLocation + SequenceLocation classes #245

Merged
merged 17 commits into from
Sep 8, 2023
Merged

refactor!: Remove ChromosomeLocation + SequenceLocation classes #245

merged 17 commits into from
Sep 8, 2023

Conversation

korikuzma
Copy link
Member

@korikuzma korikuzma commented Aug 28, 2023 •
edited
Loading

Addresses ChromosomeLocation + SequenceLocation in #235

Notes:

  • This was unnecessary. Methods were moved and renamed to the Base ETL class
    • Focuses just on moving methods out of these classes into Base ETL class. New issues can be made for changing the code in the methods (if needed)

@korikuzma korikuzma added priority:medium Medium priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup" labels Aug 28, 2023
@korikuzma korikuzma self-assigned this Aug 28, 2023
jsstevenson
jsstevenson reviewed Aug 30, 2023
View reviewed changes
gene/etl/base.py Outdated Show resolved Hide resolved
@korikuzma korikuzma mentioned this pull request Sep 8, 2023
Merged
@korikuzma korikuzma marked this pull request as ready for review September 8, 2023 17:13
@korikuzma korikuzma added priority:high High priority priority:low Low priority and removed priority:medium Medium priority priority:high High priority labels Sep 8, 2023
@korikuzma
Copy link
Member Author

@jsstevenson Couldn't make up my mind with the priority. It'd be nice if we could get this out in the same release as #239 , but if you don't have time to review we can just add in the next release. Just let me know so I know when to make a release so I can update Cool-Seq-Tool PR

Base automatically changed from issue-238 to staging September 8, 2023 17:20
jsstevenson
jsstevenson requested changes Sep 8, 2023
View reviewed changes
Copy link
Member

@jsstevenson jsstevenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"requests conversation re: comments"

gene/etl/base.py Outdated Show resolved Hide resolved
gene/etl/base.py Outdated Show resolved Hide resolved
jsstevenson
jsstevenson approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@jsstevenson jsstevenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aces

@korikuzma korikuzma merged commit e116661 into staging Sep 8, 2023
@korikuzma korikuzma deleted the cleanup branch September 8, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsstevenson jsstevenson jsstevenson approved these changes

Assignees

@korikuzma korikuzma

Labels
priority:low Low priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@korikuzma @jsstevenson