Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check different ISHTP modules according to the release (Bugfix) #1684

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

LiaoU3
Copy link
Contributor

@LiaoU3 LiaoU3 commented Jan 16, 2025

Description

This issue was originally found from LP#2077844
After 24.04 (to be more precise, after kernel 5.15), the module intel_ishtp_loader will not be automatically loaded anymomre. Hence, the modules we need to check will be different due to the series.

The commit that cause the change in Linux git repo is over here.

Resolved issues

LP#2077844

Documentation

N/A

Tests

https://certification.canonical.com/hardware/202407-34230/submission/408436/

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 95.65217% with 2 lines in your changes missing coverage. Please review.

Project coverage is 50.01%. Comparing base (04293a1) to head (844965f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
providers/base/bin/ishtp.py 95.65% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1684      +/-   ##
==========================================
+ Coverage   49.96%   50.01%   +0.05%     
==========================================
  Files         378      379       +1     
  Lines       40768    40814      +46     
  Branches     6859     6865       +6     
==========================================
+ Hits        20370    20414      +44     
- Misses      19670    19671       +1     
- Partials      728      729       +1     
Flag Coverage Δ
provider-base 26.44% <95.65%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pieqq pieqq self-requested a review March 7, 2025 08:17
@fernando79513
Copy link
Collaborator

Please merge this PR with main to fix the issues with the SRU gate.

@fernando79513 fernando79513 self-assigned this Mar 21, 2025
@fernando79513 fernando79513 added the waiting-for-changes The review has been completed but the PR is waiting for changes from the author label Mar 24, 2025
@LiaoU3 LiaoU3 removed the waiting-for-changes The review has been completed but the PR is waiting for changes from the author label Mar 28, 2025
@LiaoU3
Copy link
Contributor Author

LiaoU3 commented Mar 28, 2025

@fernando79513 Please review it when you have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants