Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run ethernet/ping_interface unless hidden manifest set (e.g. lab runs) (new) #1709

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Run ethernet/ping_interface unless hidden manifest set (e.g. lab runs) (new) #1709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5cb93f7
Create a hidden manifest to ignore disconnected Ethernet interfaces
pieqq Feb 4, 2025
29f958a
Condition run of ethernet/ping_interface to the hidden manifest
pieqq Feb 4, 2025
dd60642
Add ethernet/ping-with-any-cable-interface to the ethernet-automated …
pieqq Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions providers/base/units/ethernet/jobs.pxu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,9 @@ template-resource: device
template-filter: device.category == 'NETWORK' and device.interface != 'UNKNOWN'
id: ethernet/ping_{interface}
template-id: ethernet/ping_interface
imports: from com.canonical.plainbox import manifest
requires:
manifest._ignore_disconnected_ethernet_interfaces == 'False'
_summary: Can ping another machine over Ethernet port {interface}
_purpose: Check Ethernet works by pinging another machine
plugin: shell
Expand Down
8 changes: 7 additions & 1 deletion providers/base/units/ethernet/manifest.pxu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,10 @@ value-type: bool
unit: manifest entry
id: has_ethernet_wake_on_lan_support
_name: Wake-on-LAN support through Ethernet port
value-type: bool
value-type: bool

unit: manifest entry
id: _ignore_disconnected_ethernet_interfaces
_name: Ignore disconnected Ethernet interfaces
value-type: bool
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont recall, even though I just wrote this, you can multiline this right? if so, please do

hidden-reason: All Ethernet interfaces should be tested during enablement. However, when running regression tests in the lab, only one interface may be connected, but that should not trigger any failure.
2 changes: 2 additions & 0 deletions providers/base/units/ethernet/test-plan.pxu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ estimated_duration: 1m
include:
ethernet/detect certification-status=blocker
ethernet/ping_.* certification-status=blocker
ethernet/ping-with-any-cable-interface certification-status=blocker
bootstrap_include:
device

Expand Down Expand Up @@ -112,6 +113,7 @@ estimated_duration: 1m
include:
after-suspend-ethernet/detect
after-suspend-ethernet/ping_.*
after-suspend-ethernet/ping-with-any-cable-interface
bootstrap_include:
device

Expand Down
Loading