Add new collectors and remove fetch-on-checkpoint mechanism (New) #1788
+321
−134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1788 +/- ##
==========================================
- Coverage 49.83% 49.83% -0.01%
==========================================
Files 377 377
Lines 40719 40715 -4
Branches 6851 6837 -14
==========================================
- Hits 20294 20290 -4
Misses 19700 19700
Partials 725 725
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hook25
force-pushed
the
endof_session_collection
branch
from
9d4ee3d to
0e5567f
Compare
Minor: fix sloppy copy paste comment
pieqq
previously approved these changes
Mar 25, 2025
pieqq
previously approved these changes
Mar 26, 2025
pieqq
approved these changes
Mar 27, 2025
stanley31huang
pushed a commit
that referenced
this pull request
Mar 28, 2025
) * Add new collectors and remove fetch-on-checkpoint mechanism * Remove also the tests for ResumeSessionHelper8 * Remove dmesg as it is included in journalctl * Rollback v8 removal and add v9 to disable v8 removal * Test peeker and resume helper Minor: fix sloppy copy paste comment * Fix the actual suspend mechanism and actually test it * Also test positive branch * Journalctl json doesn't output json, but json objects stream * Fix test, all should inherit the parser and exception * Test weird journalctl output * Change default value to instead of
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is often useful to analyze the logs after a session is done to see why something went south. In order to do this, this PR adds a journal collector to system information.
This PR also moves the collection to the end of the session. I was about to create some complex machinery to run some collectors at the start of a run and some at the end, but I talked myself out of it. The collection was placed where it was placed because we thought we could use it during the run somehow. This idea went out of the window and all that is remaining now is the cost of running the collection at the start of the run, which is about 3s just to run inxi on my machine, for any session that is started, even if no submission is ever generated. I don't think the value we get (which is nothing right now) justifies this cost. If we will ever want to do something with that data during the run we can always revert (partially) this commit and tag the collectors/create functions to call them at finalize and first checkpoint, for now, I think we should do the easy thing and just collect at the end.
Resolved issues
Fixes: CHECKBOX-1753
Documentation
N/A
Tests
Tried this locally, in general I don't expect this to cause major issues as collectors can safely fail