Allow multiple local path snaps to be installed #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschimke95
reviewed
Feb 19, 2025
There was a problem hiding this comment.
What else is required for #104 to be resolved? Can we just add it here?
claudiubelu
force-pushed
the
install-multiple-local-path-snaps
branch
from
cedbd8c to
6c3b35b
Compare
In airgapped environments, multiple snaps may be downloaded and then installed from local paths. The k8s snap depends on core20 snap. With this change, /capi/etc/snap-local-path may be a folder containing local snaps to install. This change preserved the old behaviour.
claudiubelu
force-pushed
the
install-multiple-local-path-snaps
branch
from
6c3b35b to
d335d05
Compare
I think this should be enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In airgapped environments, multiple snaps may be downloaded and then installed from local paths. The
k8ssnap depends oncore20snap.With this change, /capi/etc/snap-local-path may be a folder containing local snaps to install. This change preserved the old behaviour.
Fixes: #104