bug: fix CK8sInitConfiguration defaults #113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll update the "BaseUserData" docstrings, clarifying the difference between the "BootstrapConfig" and "ConfigFileContents" fields. One contains the bootstrap config generated by the ck8s provider, the other can contain user-provided configuration that overrides the generated config.
The following settings are enabled by default even if the network feature is disabled: * EnableDefaultGateway * EnableDefaultLoadBalancer * EnableDefaultIngress This causes bootstrap failures if the network feature is disabled. To address this, we'll set these default values based on the network feature. Fixes: #106
eaudetcobello
approved these changes
Feb 27, 2025
We'll collect the test artifacts in order to be able to debug test failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following settings are enabled by default even if the network feature is disabled:
This causes bootstrap failures if the network feature is disabled.
To address this, we'll set these default values based on the network feature.
While at it, we'll fix the "BaseUserData" docstrings, clarifying the difference between the "BootstrapConfig" and "ConfigFileContents" fields.
Fixes: #106