feat: models for the craft manifest #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are three new models: - ProjectManifest, representing the metadata from the project itself and its built artifact; - SessionArtifactManifest, representing the metadata for a single asset that was downloaded during the fetch-service session; - CraftManifest, that ties the first two together and provides the full view of assets downloaded and generated by a build.
tigarmo
requested review from
lengau,
a team and
cmatsuoka
and removed request for
a team
tigarmo
commented
Sep 17, 2024
tigarmo
commented
Sep 17, 2024
lengau
reviewed
Sep 17, 2024
lengau
reviewed
Sep 18, 2024
Co-authored-by: Alex Lowe <[email protected]>
cmatsuoka
reviewed
Sep 19, 2024
linostar
pushed a commit
to linostar/craft-application
that referenced
this pull request
Dec 4, 2024
There are three new models: - ProjectManifest, representing the metadata from the project itself and its built artifact; - SessionArtifactManifest, representing the metadata for a single asset that was downloaded during the fetch-service session; - CraftManifest, that ties the first two together and provides the full view of assets downloaded and generated by a build. --------- Co-authored-by: Alex Lowe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three new models:
ProjectManifest, representing the metadata from the project itself and its built artifact;
SessionArtifactManifest, representing the metadata for a single asset that was downloaded during the fetch-service session;
CraftManifest, that ties the first two together and provides the full view of assets downloaded and generated by a build.
Have you followed the guidelines for contributing?
Have you signed the CLA?
Have you successfully run
tox?