Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for RK042 - Guard against pro builds on "devel" bases - 10/02/25 #640

Conversation

clay-lake
Copy link

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint && make test?
  • Have you added an entry to the changelog (docs/reference/changelog.rst)?

The purpose of this PR is to introduce a preliminary check for --pro enabled builds to avoid commands on "devel" bases.

@clay-lake clay-lake changed the base branch from main to feature/pro-sources February 10, 2025 22:08
@clay-lake clay-lake force-pushed the feature/pro-sources_error_on_pro_devel_builds branch from 9363ef7 to 7e312ea Compare February 16, 2025 19:18
@clay-lake clay-lake marked this pull request as ready for review February 16, 2025 19:20
@clay-lake
Copy link
Author

Hey @tigarmo && @canonical/starcraft-reviewers, could I get this merged in? :)

@mr-cal mr-cal requested a review from tigarmo February 18, 2025 13:50
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lengau lengau merged commit a4ace66 into canonical:feature/pro-sources Feb 18, 2025
8 of 9 checks passed
@mr-cal mr-cal removed the request for review from tigarmo February 18, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants