fix: at plugin load time, emitter is not yet initialized #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dariusz Duda <[email protected]>
mattculler
force-pushed
the
work/CRAFT-4019-load-lib-emitter-fix
branch
from
3965a68 to
80739d0
Compare
lengau
reviewed
Feb 11, 2025
lengau
approved these changes
Feb 12, 2025
lengau
pushed a commit
that referenced
this pull request
Feb 13, 2025
* fix: at plugin load time, emitter is not yet initialized * fix(tests): emitter -> logger * chore: format * fix(uv): add conflict group * chore: trying to fix trivy ci * fix: remove offending sections * fix(perf): don't interpolate string before logging Co-authored-by: Dariusz Duda <[email protected]> * feat: make sure to set up the self-named logger * feat: reimplement: load plugins after loggers initialized * feat(test): add unit test for plugin failure * feat: redo previously agreed on emission level --------- Co-authored-by: Dariusz Duda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make lint && make test?docs/reference/changelog.rst)?(CRAFT-4019)