[PROTOTYPE] feat(apt_sources_manager): support foreign architectures #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Callahan Kovacs <[email protected]>
lengau
reviewed
Feb 5, 2025
| """Return true if the default sources are in deb822 format.""" | ||
| # TODO | ||
|
|
||
| return bool("You're using core24, right?") |
lengau
reviewed
Feb 5, 2025
| # Sources in 'ubuntu.sources' don't list architectures, so apt assumes the default | ||
| # repository can serve all architectures. These need to be restricted before adding | ||
| # other architectures with `dpkg --add-architecture`. | ||
| if _is_deb822_default(): |
There was a problem hiding this comment.
For a non-experimental version, maybe we just replace sources.list with a deb822 format? dpkg supports it at least as far back as focal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make lint && make test?This prototype allows for installing packages from foreign architectures for
apt.An example project for this can be found here: https://github.com/mr-cal/curl-consumer
Fixes #104
Unblocks canonical/snapcraft#5222
(CRAFT-2425)