Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(distro): make series comparison less strict #49

Merged
merged 3 commits into from
Sep 24, 2024
Merged

fix(distro): make series comparison less strict #49

merged 3 commits into from
Sep 24, 2024

Conversation

lengau
Copy link
Contributor

@lengau lengau commented Sep 19, 2024 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

Fix for canonical/craft-application#455

@lengau lengau force-pushed the work/less-strict-versions branch from 05d447a to 9aad820 Compare September 19, 2024 20:44
@lengau lengau requested a review from a team September 19, 2024 20:47
mr-cal
mr-cal approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, you can take or leave the refactoring suggestion

craft_platforms/_distro.py Outdated Show resolved Hide resolved
@lengau lengau requested a review from a team September 23, 2024 23:54
@lengau lengau merged commit e28b943 into main Sep 24, 2024
13 checks passed
@lengau lengau deleted the work/less-strict-versions branch September 24, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigarmo tigarmo tigarmo approved these changes

@mr-cal mr-cal mr-cal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lengau @tigarmo @mr-cal