Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/cgroup: on cgroup1 systems, the swap limit is set to limits.memory * 2 #272

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

simondeziel
Copy link
Member

No description provided.

@simondeziel simondeziel force-pushed the cgroup1-memlimit branch 2 times, most recently from 518a70b to 0116c48 Compare August 20, 2024 19:27
tests/cgroup Fixed Show fixed Hide fixed
@simondeziel
Copy link
Member Author

simondeziel commented Aug 20, 2024

As mentioned in chat, I think that trying to make all tests work on 20.04 with modern LXD is going to be a time sync. Expanding the exclusion matrix to limit what is tested on 20.04 is probably the way to go (rather than merging this PR).

Even with the swaptotal issue fixed, the tests/cgroup script fails a bit later on the limits.network.priority test, see https://github.com/simondeziel/lxd-ci/actions/runs/10478158697/job/29020868221#step:8:498

@tomponline
Copy link
Member

Lets wait until @mihalicyn has a look, if this is expected behaviour then we can indeed test for it.

@tomponline tomponline requested a review from mihalicyn October 4, 2024 08:06
@tomponline
Copy link
Member

@mihalicyn @simondeziel do we still need this?

@tomponline
Copy link
Member

Any news chaps @mihalicyn @simondeziel ?

@simondeziel
Copy link
Member Author

This has stopped being a pain point in CI because we no longer test 5.0 on cgroup1 systems (20.04). I'm not sure if the PR does the right thing (accept different limits based on the LXD version) or if LXD should always use the same limit between every versions.

I guess it's a bit late to change LXD's behaviour now so this PR should be considered if we want to start testing 5.0 on 20.04 again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants