Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Add all projects support for network zones (from Incus) #14585

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

kadinsayani
Copy link
Contributor

@kadinsayani kadinsayani commented Dec 4, 2024

This PR adds support for fetching network zones across all projects.

@github-actions github-actions bot added Documentation Documentation needs updating API Changes to the REST API labels Dec 4, 2024
@kadinsayani kadinsayani force-pushed the all-projects-network-zones branch 2 times, most recently from 2d261ad to 80b5b3f Compare December 4, 2024 23:14
@kadinsayani kadinsayani changed the title Network: Add all projects support for network zones (from Incus) API: Add all projects support for network zones (from Incus) Dec 4, 2024
@kadinsayani kadinsayani force-pushed the all-projects-network-zones branch from 80b5b3f to 6699a45 Compare December 4, 2024 23:23
@kadinsayani kadinsayani changed the title API: Add all projects support for network zones (from Incus) WIP: API: Add all projects support for network zones (from Incus) Dec 4, 2024
@kadinsayani kadinsayani force-pushed the all-projects-network-zones branch 4 times, most recently from 2755a82 to 5376741 Compare December 5, 2024 17:12
@kadinsayani kadinsayani changed the title WIP: API: Add all projects support for network zones (from Incus) API: Add all projects support for network zones (from Incus) Dec 5, 2024
@kadinsayani kadinsayani marked this pull request as ready for review December 5, 2024 17:15
@kadinsayani kadinsayani marked this pull request as draft December 5, 2024 17:16
@kadinsayani kadinsayani force-pushed the all-projects-network-zones branch 3 times, most recently from c7a7b9d to 3ca570e Compare December 5, 2024 22:43
@markylaing
Copy link
Contributor

@kadinsayani can you rebase please? Also do you still want me to review?

@kadinsayani
Copy link
Contributor Author

kadinsayani commented Dec 9, 2024

@kadinsayani can you rebase please? Also do you still want me to review?

Sure thing. And yes, please - I'm currently having trouble getting the authorization tests to pass.

@kadinsayani kadinsayani force-pushed the all-projects-network-zones branch from 3ca570e to ae61f5d Compare December 9, 2024 17:31
@kadinsayani kadinsayani marked this pull request as ready for review December 9, 2024 17:31
@kadinsayani kadinsayani marked this pull request as draft December 10, 2024 01:16
@kadinsayani
Copy link
Contributor Author

I'm going to mark this as draft until I have the tests passing, so we can hold off on reviews for now. I've just found this which we may want to include here as well: lxc/incus@9bdeb59.

cc. @markylaing @tomponline

@kadinsayani kadinsayani force-pushed the all-projects-network-zones branch 2 times, most recently from 00213f7 to 985d40b Compare December 10, 2024 17:24
Signed-off-by: Mohamed Ilaiwi <[email protected]>
(cherry picked from commit 41842f2517cbba7e47445520dce5e89102d6b0d1)
Signed-off-by: Kadin Sayani <[email protected]>
License: Apache-2.0
Signed-off-by: Mohamed Ilaiwi <[email protected]>
(cherry picked from commit 308834b2d127ca2a42adfee8dc5fc9f18980a036)
Signed-off-by: Kadin Sayani <[email protected]>
License: Apache-2.0
Signed-off-by: Mohamed Ilaiwi <[email protected]>
(cherry picked from commit f2864c23250e80d2f057c3e0a70743244005721a)
Signed-off-by: Kadin Sayani <[email protected]>
License: Apache-2.0
kadinsayani and others added 7 commits December 10, 2024 10:25
Signed-off-by: Kadin Sayani <[email protected]>
Signed-off-by: Mohamed Ilaiwi <[email protected]>
(cherry picked from commit 48f3de4b84402faef1741e595292d6d284fd830b)
Signed-off-by: Kadin Sayani <[email protected]>
License: Apache-2.0
Signed-off-by: Mohamed Ilaiwi <[email protected]>
(cherry picked from commit 3faef152f823f2321dbba18886403195b7ab18d1)
Signed-off-by: Kadin Sayani <[email protected]>
License: Apache-2.0
Signed-off-by: Mohamed Ilaiwi <[email protected]>
(cherry picked from commit f7dc5896def59a6adc8964af0bf10b15e76d9804)
Signed-off-by: Kadin Sayani <[email protected]>
License: Apache-2.0
Signed-off-by: Kadin Sayani <[email protected]>
@kadinsayani kadinsayani force-pushed the all-projects-network-zones branch from 985d40b to b34edd1 Compare December 10, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Changes to the REST API Documentation Documentation needs updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants